install Zig if the zig.path config option has been unset
#400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The difference this change makes can be easily observed by editing a build.zig.zon while using the builtin version manager. ZLS would be restarted every time the file is edited even if it is has no `minimum_zig_version`.
The ZigProvider does not update the zig version when the `zig.path` has been removed because it isn't aware of the version managment system. To resolve this, the logic is moved into zigSetup.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ZigProvider does not update the zig version when the
zig.pathhas been removed because it isn't aware of the version managment system. To resolve this, the logic is moved into zigSetup.ts.Also includes a commit that avoids unnecessarily triggering zig provider on change events.